CHOLMOD: Prefer RefValue to Ref for fields and type-assertions - #755
Merged
Conversation
`getcommon` asserted the abstract `Ref{cholmod_common}` on the value it
fetches from task-local storage, and `Factor` typed its scratch buffers `X`,
`Y` and `E` as the abstract `Ref{Ptr{...}}`. With those abstract types every
`common[]`, every wrapper call taking it, and every read of the buffers was a
dynamic call, which kept the whole CHOLMOD layer from compiling under juliac's
`--trim`. The values are always `RefValue`s; say so.
This commit was written with the assistance of generative AI (Claude).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
topolarity
force-pushed
the
ct/trim-cholmod
branch
from
September 2, 2026 23:29
28ebe68 to
ae2ecaf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 83.85% 83.35% -0.50%
==========================================
Files 13 13
Lines 9387 9367 -20
==========================================
- Hits 7871 7808 -63
- Misses 1516 1559 +43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
araujoms
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refis an abstract type, soRefValueis needed in these positions instead to keep everything type-stable.